Restore __cplusplus guard absent from oid.h - #10927
Open
HelloOO7 wants to merge 1 commit into
Open
Conversation
Signed-off-by: HelloOO7 <cendarehor@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since release 4.0.0,
mbedtls/oid.hno longer includes anextern "C"guard for when the header is used from C++ code. This makes such C++ code fail to compile with an undefined reference error unless manually wrapped inextern C. I've had this happen in an ESP-IDF project.This appears to be a regression, as the guard was present up until and including this commit:
mbedtls/include/mbedtls/oid.h
Line 469 in 791fc2e
Since this looked like a rather rudimentary bug to fix, I've created this PR to restore the appropriate preprocessor guards to the file. I apologize if this should have been an issue first, it did not appear necessary to me to create one for such a tiny little thing.
PR checklist