Skip to content

3.6 only: Fix possible miscompilation of ssl_hostname_skip_cn_verification hack - #10843

Open
gilles-peskine-arm wants to merge 1 commit into
Mbed-TLS:mbedtls-3.6from
gilles-peskine-arm:ssl-hostname-fix-magic-pointer-3.6
Open

3.6 only: Fix possible miscompilation of ssl_hostname_skip_cn_verification hack#10843
gilles-peskine-arm wants to merge 1 commit into
Mbed-TLS:mbedtls-3.6from
gilles-peskine-arm:ssl-hostname-fix-magic-pointer-3.6

Conversation

@gilles-peskine-arm

Copy link
Copy Markdown
Contributor

Fix #10842

PR checklist

  • changelog provided
  • framework PR not required
  • TF-PSA-Crypto development PR not required because: TLS only
  • TF-PSA-Crypto 1.1 PR not required because: TLS only
  • mbedtls development PR not required because: the bug is only present in LTS branches up to 3.6 where we needed a hack to preserve the ABI
  • mbedtls 4.1 PR not required because: the bug is only present in LTS branches up to 3.6 where we needed a hack to preserve the ABI
  • mbedtls 3.6 PR provided here
  • tests not required because: the only consequence is possible miscompilation on some compilers that we don't have on our CI

…ification

Fix mbedtls_ssl_set_hostname(ssl, NULL) causing the connection to
fail when compiled with some versions of IAR in configurations
with MBEDTLS_SSL_SERVER_NAME_INDICATION disabled. Also fix
mbedtls_ssl_set_hostname(ssl, "") which could disable hostname
verification instead of requiring an empty hostname when compiled
with some optimizing compilers. Fixes Mbed-TLS#10842.

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added bug needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits labels Jul 23, 2026
@gilles-peskine-arm gilles-peskine-arm added the size-xs Estimated task size: extra small (a few hours at most) label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug component-tls needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)

Projects

Status: In Development

Development

Successfully merging this pull request may close these issues.

2 participants