Add input length validation in dummy_ticket_parse() - #10831
Open
honma89 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Nim Dorji Subba <nimdorjisubba2003@gmail.com>
honma89
force-pushed
the
fix-memory-errors
branch
from
July 14, 2026 14:01
58abc52 to
42a303b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a length check in
dummy_ticket_parse()before parsing the TLS session ticket.Previously, the function assumed that the ticket buffer was always large enough and directly used
len - 4. If a smaller buffer was provided, this could cause an unsigned integer underflow and pass an invalid length value tombedtls_ssl_session_load().This change ensures invalid ticket buffers are rejected early by returning
MBEDTLS_ERR_SSL_BAD_INPUT_DATA.PR checklist