[persist] Remove log and tidy up listen validation #33187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes up more often than you'd hope: not everyone checks the handle's since, and there are various valid reasons that the since might be past where we're trying to read. (Sink restarting, etc.) Remove for now.
The only caller doesn't care about this, and anyways there are good theoretical reasons for the reader to not care about the upper.
teskje
approved these changes
Jul 31, 2025
DAlperin
approved these changes
Jul 31, 2025
The log always triggered in cases where's it's acceptable to suspend-and-restart, so let's do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
https://github.com/MaterializeInc/database-issues/issues/9510
Cleaning up the Machine::validate_listen and similar isn't strictly necessary, but might as well.