Skip to content

Update tooling and protocols #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 25, 2017
Merged

Update tooling and protocols #15

merged 10 commits into from
Oct 25, 2017

Conversation

georgiosd
Copy link
Contributor

No description provided.

@georgiosd
Copy link
Contributor Author

Not sure why the check is failing, compiles fine here.

@qmfrederik
Copy link
Contributor

It looks like it's related to the .NET Core tooling. I'll try to have a look at it later this week - ping me if you do not hear back from me.

@georgiosd
Copy link
Contributor Author

Weird, I didn't change anything to the project itself.

@georgiosd
Copy link
Contributor Author

Some of these changes are breaking but useful. If you'd like to keep backwards-compatibility, you're welcome to modify them - obvious, I know :)

@qmfrederik
Copy link
Contributor

@georgiosd There are some merge conflicts because the code which supports optional attributes has been merged.

Could you rebase this against master and update the PR? You'll also need to re-generate the classes since optional attributes will now be marked properly.

@georgiosd
Copy link
Contributor Author

Sorry for the delay, will try to get to it this week

@georgiosd
Copy link
Contributor Author

Guys, apologies but I no longer have a need for this and very little time right now.
You're welcome to merge the changes (as much or as little of) but unfortunately I can't spend more time on this right now...

@qmfrederik
Copy link
Contributor

@georgiosd Thanks for the heads up! I'll probably have a look at this in the future, no promises though :)

@brewdente brewdente merged commit f37da53 into MasterDevs:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants