Some issues with i3 tiling WM.

[kminehart]

I'm not using a DE, only the WM called "i3". See here: https://i3wm.org/

I think the issues might be because of the custom window borders and not allowing the WM to control the application? For example, I can't super+shift+q to exit, which executes kill. Clicking the X, fullscreen, or minimize does nothing either.

I'll see if I can do anything to help with this, I made a fork for my changes:

https://github.com/pascalsoftware/Google-Play-Music-Desktop-Player-UNOFFICIAL-

[kminehart]

A note from i3s docs:

If an application does not provide a mechanism for closing (most applications provide a menu, the escape key or a shortcut like Control+w to close), you can press $mod+Shift+q to kill a window. For applications which support the WM_DELETE protocol, this will correctly close the application (saving any modifications or doing other cleanup). If the application doesn’t support the WM_DELETE protocol your X server will kill the window and the behaviour depends on the application.

However, using Control+W also does not kill the application.

[AnotherKamila]

Also seeing this in i3.

Additionally, if I switch to the miniplayer while in tiling mode, the window size is different than what the miniplayer expects, and it becomes very unhappy about this (constantly redrawing itself to the expected and actual size in a loop). As the miniplayer expects a fixed window size, probably telling the WM to float it is the most reasonable behavior (or you could make it resizable => me happy :D).

[kminehart]

Update:
in src/index.js I added

    // Emitted when the user tries to close the application.
    mainWindow.on('close', () => {
      console.log('close');
    });

and when I make an attempt to close the application, either with super+shift+q, or with the x, or ctrl+w, the event gets fired and 'close' is printed on the console. At this point I'm not familiar enough with the application to correctly handle a close, but I'm working on it.

Default behavior is probably being prevented somewhere.

[kminehart]

Here's the perpetrator:

So at the moment if anyone else is having this problem, make sure to disable "minimize to tray" in the desktop settings, then it should work fine! It looks like i3 and electron don't like to play nice when trying to hide a window, since i3 really has no way to hide a window.

mainWindow.on('close', (event) => {
  if ((Settings.get('minToTray', true) || process.platform === 'darwin') && !global.quiting) {
    if (process.platform !== 'darwin') {
      mainWindow.minimize();
      mainWindow.setSkipTaskbar(true);
    } else {
      if (PlaybackAPI.isPlaying()) {
        Emitter.sendToGooglePlayMusic('playback:playPause');
      }
      mainWindow.hide();
    }
    event.preventDefault();
    return;
  }

[AnotherKamila]

Yes, this works. BTW, other applications (e.g. VLC or Gajim) can "minimize" to tray in i3, but it is possible that they actually destroy the window.

[kminehart]

Indeed, they would have to destroy the window. i3 does not technically have a way to minimize a window.

As for the issue at hand, I am unable to find a good fix for it. It would be easy, but Electron does not have window.minimizable implemented on Linux. I opened an issue here: electron/electron#4696

[MarshallOfSound]

Did some quick research into this it's definitely an electron bug and should be tracked there 👍

I'll watch the issue there and chime in if needed

[zetxx]

i think that this issue should be reopened. issue exists at current version

[tekjanson]

I am also having this issue with i3 on current build

[Block81838]

same issue