Add support for stable rust #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to do this, when `--features nightly` is not enabled: - There is no default implementation of `Finalize`, meaning that it must be manually implemented (for example, by the new `#[derive(Finalize)]` custom derive implementation). - There is no support for `CoerceUnsize` so it is hard (impossible?) to create `Gc<T> where T: ?Sized`. - The tree now contains dummy no-op implementations of `Shared<T>` and `NotNull<T>`, which are used in stable rust. Fixes #46
|
\o/ |
andersk
added a commit
to andersk/rust-gc
that referenced
this pull request
Feb 1, 2021
I converted this from feature(optin_builtin_traits) in Manishearth#111, but in fact this has been unused since Manishearth#51 removed the explicit negative impls for !Send and !Sync. Signed-off-by: Anders Kaseorg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to do this, when
--features nightlyis not enabled:Finalize, meaning that itmust be manually implemented (for example, by the new
#[derive(Finalize)]custom derive implementation).CoerceUnsizeso it is hard (impossible?) tocreate
Gc<T> where T: ?Sized.Shared<T>andNotNull<T>, which are used in stable rust.Fixes #46