Skip to content

Conversation

behackl
Copy link
Member

@behackl behackl commented Jun 30, 2024

Ongoing post-pyav refactor: fixes #3831

  • cleanup inconsistently named containers/streams in added code
  • think about actually opening file to check codec
  • deal with files that have mulitple audio streams? (try whether this actually works currently)
  • maybe add a test?

@behackl behackl added the pr:bugfix Bug fix for use in PRs solving a specific issue:bug label Jul 14, 2024
@behackl behackl added this to the v0.19.0 milestone Jul 14, 2024
@behackl behackl marked this pull request as ready for review July 14, 2024 21:41
@behackl
Copy link
Member Author

behackl commented Jul 14, 2024

I've cleaned up the re-encoding of non-wav/raw files, made sure the solution also works with multiple audio channels, and added a test. Ready to be reviewed!

The test uses the manim_caplog fixture introduced in #3680, so it will only pass after that PR is merged.

Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonGrace2282 JasonGrace2282 enabled auto-merge (squash) August 14, 2024 15:19
@JasonGrace2282 JasonGrace2282 merged commit d029beb into ManimCommunity:main Aug 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:bugfix Bug fix for use in PRs solving a specific issue:bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Post PyAV-Refactor: make sure pydub is only fed .wav or .raw files
2 participants