Skip to content

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Jun 22, 2024

@JasonGrace2282 JasonGrace2282 requested a review from chopan050 June 22, 2024 03:11
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left some minor suggestions around the code.
As a side note, I noticed that I myself missed some things regarding backreferences and format in #3484, such as some :class: or ~typing. prefixes and using single instead of double backticks for some names, and I'd like to make a separate PR fixing them

Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@chopan050 chopan050 enabled auto-merge (squash) June 26, 2024 14:43
@chopan050 chopan050 merged commit 93a20cd into ManimCommunity:main Jun 26, 2024
@JasonGrace2282 JasonGrace2282 deleted the typevar branch June 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Autoaliasattr: TypeVar
2 participants