Skip to content

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented May 14, 2024

Change pyupgrade from suggesting 3.7 upgrades to 3.9 upgrades

@JasonGrace2282 JasonGrace2282 added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label May 14, 2024
@@ -53,6 +53,6 @@
from .core import *
from .manim_colors import *

_all_color_dict: Dict[str, ManimColor] = {
_all_color_dict: dict[str, ManimColor] = {

Check notice

Code scanning / CodeQL

Unused global variable

The global variable '_all_color_dict' is not used.
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@JasonGrace2282 JasonGrace2282 merged commit 203a536 into ManimCommunity:main May 15, 2024
@JasonGrace2282 JasonGrace2282 deleted the update-pre-commit branch May 15, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants