Add @ shorthand for CoordinateSystem methods coords_to_point (c2p) and point_to_coords (p2c)
#3754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
behackl
added
the
new feature
behackl
approved these changes
May 9, 2024
Viicos
requested changes
May 9, 2024
| def __matmul__(self, coord: Point3D | Mobject): | ||
| if isinstance(coord, Mobject): | ||
| coord = coord.get_center() | ||
| return self.coords_to_point(*coord) |
There was a problem hiding this comment.
Suggested change
| return self.coords_to_point(*coord) | |
| return self.coords_to_point(coord) |
?
Probably a test would be nice
There was a problem hiding this comment.
The problem with removing the * is that ax @ (1, 0, 0) then returns a 3x3 array, which I felt was kinda unintuitive.
As for the test, I already have a doctest in Axes. Is another test really necessary?
There was a problem hiding this comment.
In the interest of getting this merged, I went ahead and added a test for the behavior.
Co-authored-by: Victorien <[email protected]>
|
I just added it to |
chopan050
changed the title
@ shorthand for CoordinateSystem methods coords_to_point (c2p) and point_to_coords (p2c)
|
Will get back to the unresolved comment soon |
Viicos
approved these changes
May 27, 2024
Co-authored-by: Victorien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
ax @ (1, 0, 0)forcoords_to_pointand(1, 0, 0) @ axforpoint_to_coordsInspired by @abul4fia