A bug about gridHeight caused by maxRows

[natee]

source code line 401.

console.log("realRows:",maxHeight,'maxRows:',this.maxRows);
this.gridHeight = Math.min(this.maxRows, maxHeight);

You set gridHeight with the 'min' math function,then,when you set the 'maxRows:1' in your 'gridsterOptions' ,the 'gridHeight' may always be 1.

source code line 544.

var updateHeight = function() {
    $elem.css('height', (gridster.gridHeight * gridster.curRowHeight) + gridster.margins[0] + 'px');
    $elem.css('height', (gridster.gridHeight * gridster.curRowHeight) + (gridster.outerMargin ? gridster.margins[0] : -gridster.margins[0]) + 'px');
};

here,the $elem's width may always be 'curRowHeight + margins'.

So I changed the line 401 code to:

this.gridHeight = this.maxRows - maxHeight > 0 ? Math.min(this.maxRows, maxHeight) : Math.max(this.maxRows, maxHeight);

[danomatic]

Are you saying you want to be able to have items with a height > 1 in a grid with a maxRows of 1?

[natee]

yes
when I set maxRows of 1,i tried to resize the item more than one row,then there occured a problem

[danomatic]

Max rows is generally supposed to be the max total rows, so a maxRows of 1 should probably not allow an item with a height greater than 1.

[natee]

I have known what you mean,but there is still some problems.
Let me re-describe the problem :

1. Use the default settings,when I drag or resize the item,the wrapper's height is wrong,the bottom has a white space area.
2. When I set the maxRows to a number(1 or other) 'n',then the total items are actually more than 'n' rows ,the wrapper's height is too small.

You can see these problems in you live demo.
https://rawgit.com/ManifestWebDesign/angular-gridster/master/index.html#/dashboard .

1. When you drag one item more than one row,then the wrapper's height maybe wrong?
2. Set maxRows to 1 and add 5 items,the wrapper's height maybe fixed?

Maybe you design this for your maxRows purpose,but when I want to restrict every item only one row,and the total row is > 1 ,then I will set maxRow to 1(this is problem 2),so I have to change your code to fit my purpose.I think my change solved problem 2.

So, I think problem 2 may be a new feature,but problem 1 is a problem.