Rails 7.1 deprecated pool_size in AS::Cache::Store/removed in 7.2 #23507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note, ManageIQ::Session goes through ActionDispatch::Session::SessionObject TokenManager#token_store goes through ActiveSupport::Cache::MemCacheStore. This commit resolves the deprecated and removed support for pool_size in AS::Cache::Store in 7.2 Before: ``` vmdb(dev)> TokenManager.new.send(:token_store).instance_variable_get(:@DaTa).size => 5 vmdb(dev)> ManageIQ::Session.store.instance_variable_get(:@DaTa).size => 10 ``` After: ``` vmdb(dev)> TokenManager.new.send(:token_store).instance_variable_get(:@DaTa).size => 10 vmdb(dev)> ManageIQ::Session.store.instance_variable_get(:@DaTa).size => 10 ```
jrafanie
force-pushed
the
fix-pool-size-in-token-store
branch
from
2b1561c to
37b5d9d
Compare
|
Checked commit jrafanie@37b5d9d with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint |
kbrock
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, ManageIQ::Session goes through ActionDispatch::Session::SessionObject.
TokenManager#token_store goes through ActiveSupport::Cache::MemCacheStore.
This commit resolves the deprecated and removed support for pool_size in AS::Cache::Store in 7.2.
Followup to #23424
Before:
After: