Unify queue multiselect look with playlist screen (reopenend)#237
Merged
Malopieds merged 1 commit intoMalopieds:devfrom Aug 9, 2024
Merged
Unify queue multiselect look with playlist screen (reopenend)#237Malopieds merged 1 commit intoMalopieds:devfrom
Malopieds merged 1 commit intoMalopieds:devfrom
Conversation
mostafaalagamy
left a comment
There was a problem hiding this comment.
There's a issue when moving the queue list items to arrange the songs by dragging.
Screenrecorder-2024-07-31-01-45-14-446.mp4
Author
|
Thanks for testing! I'm not at my PC for some time, but when I am I will definetly look into that. |
Author
|
But generally I'm not quite sure if the design is well made or suitable for the queue. |
Owner
|
This one was messy but I think it's a good implementation ! I just changed some things:
Other than that, a big thank you for this ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is already a multiselect look in the playlist screen, so the provisionally looking check boxes in the queue don't seem to be necessary in my opinion.
This is what I thought would work well (The screen record also includes the commits from #233):
demo.mp4
I'm open for suggestions and improvements!