Use fixed vertical FOV for wide aspect ratios #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you have an ultrawide monitor, the fixed-horizontal field of view means you're going to see the same amount horizontally, and it's only going to cut off the top and bottom. It'd be a lot better if a wider monitor fixes the vertical field of view in place and allows you to see more horizontally. This pull request makes that the case - if you are playing in an aspect ratio higher than 16/9, then the vertical FOV will be fixed and the horizontal FOV will expand, looking much more natural.
Comparison screenshots: (for whatever reason I picked 1920x720 as the aspect ratio for the ultrawide shots, which is 8:3 and not a ratio that I've heard used at all lol but it gets the point across)
These screenshots serve to demonstrate how anything below 16:9 looks exactly the same (this does not sacrifice vertical FOV when playing in 4:3, for example), and for anything higher than 16:9, the vertical FOV matches 16:9 and the horizontal FOV is expanded naturally.
I make this PR for the selfish reason of: I visited my family this weekend, they have an ultrawide monitor setup and mbu looked bad on it so now is the time to fix it lol
Code mostly ported from PQ's MBExtender hax. Don't have the exact credits so:
Copyright (c) 2017, The Platinum TeamPotential future work: clamp UI elements to remain inside a 16:9 box