Gh 788 multinode test review5 #627
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* GH-591: The card's main objectives are done * GH-591: a little refactoring * GH-591: undoing some changes as they were interferring with multinode tests * GH-591: removed commented out lines --------- Co-authored-by: Bert <[email protected]>
* Tests passing * Removed dead code * Moved test back where it belongs * Formatting * Finished TEST_DEFAULT_CHAIN update * More BaseSepolia stuff * Corrected host and port detection in protocol packs; about to make ports non-optional * Abandoning this approach; will revert, but wanted to preserve * Revert "More BaseSepolia stuff" This reverts commit 10735ad. * Everything's compiling now * Interim commit * Fixed the protocol pack * Review issues
czarte
commented
Apr 29, 2025
| @@ -538,9 +539,10 @@ pub mod tests { | |||
| ); | |||
| assert!( | |||
| result.contains(expected_one) || result.contains(expected_two), | |||
| "result was not containing neither of those {:?}, nor {:?}", | |||
| "result should have contained either {:?}, nor {:?}, but was instead {:?}", | |||
There was a problem hiding this comment.
should be or, not nor
dnwiebe
approved these changes
Apr 29, 2025
* remove data from dbip_country.rs - prepared for actions build * Added DBIP file generation * ci: improve GitHub Actions workflow - Replace s3-sync-action with AWS CLI, update credentials handling, improve cache invalidation * refactor: improve path resolution and code quality in generate_dbip * ci: remove unnecessary dependencies and update generate dbip step * chore: remove unused generate_dbip_country.sh script * docs: update download script message to reference cargo command * refactor: Improve generate_dbip.rs organization and efficiency * fix: Update dbip_country.rs paths in CI workflow to use temp directory * fix: Update verification pattern for generated dbip file * ci: revert platform changes to legacy * ci: update windows specific file move to use bash * ci: corrected verification step * Room for an MMDB parser * Generating countries, rudimentary * parse() should produce a Countries object, instead of Vec<(String, String)>. Gonna do that. * Interim commit * Must make tests self-adapting * No MMDB yet, but tests pass * About to try bringing in an actual DBIP file * Happy-path test passing * MMDB parser seems to be finished * Now MMDB parser isn't as wasteful * Removed dead data * Tests all pass * Merge mostly complete; lots of tests pass. Maybe all of them? * One test failing. Can't figure why. * All masq tests passing now * Multinode tests pass; one bit of code cleanup remains * All tests should be passing * Removed dead code * Little surgery on modules and imls * Updated the CSV country list from MMDB * Started GitHub Actions file for monthly downloads * conditions for failing download and gargo run, to not continue, file names in generate and commit * Going to try out the dbip_download workflow * Temporary on: * generate dbip_country.rs workflow and checkout dbip_country.rs from separate branch in ci-matric workflow * resolved most failing tests, now failing debut_with_node_addr_not_accepting_connections_is_rejected for no reason, wierd behaviour of qualifies * fixing failing tests * comment out fetch dbip, and remove unwanted action build dbip * try to fix actions * all countries in test dbip_country.rs * removing misstake * added checkout of read dbip_country.rs from DBIP-Experiment * new workflow: in local we work with reduced dbip, but on ci/all.sh we checking out full version from git, same in actions, remove PARENT_DIR variable for Jenkins * testing git pre-commit hook * update pre-commit hook * remove checkout of dbip_country.rs from ci-matrix, it will be handled by ci/all.sh * testing pre-commit hooks changes * testing commit hook * testing pre commit hook * testing pre commit hook * final polishing of pre-commit hook * addressed comments from Review * formatting * addressing review comments, plus fix double entry of ip_country in modules.xml * Enabled IDE tests in ip_country * Fixed module-definition problem, addressed two review comments * Weird stuff with TryFrom and From * addressing review comments * fix ci.all condition for chekout dbip * remove comments and exit in ci/all.sh * added dbip_download github workflow (#637) * added dbip_download github workflow * change to run every day on midnight for QA * Master gh 580 b dbip download workflow (#639) * added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * Master gh 580 b dbip download workflow (#641) * added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch * generated-source from Node repo * dbip download workflow for master * adjust cron shedule for dbip download * Master gh 580 b dbip download workflow (#643) * Master gh 580 b dbip download workflow (#644) * added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch * fix generated-source branch name in condition * increse standard timeout milis const * manual trigger and debugging flags to runs * use variable to store git ls-remote command * Master gh 580 b dbip download workflow (#647) * added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch * fix generated-source branch name in condition * increse standard timeout milis const * manual trigger and debugging flags to runs * use variable to store git ls-remote command * add git fetch before checkout * Master gh 580 b dbip download workflow (#648) * added dbip_download github workflow * change to run every day on midnight for QA * necesary changes to be able build dbip_country.rs on master * -p for generating ip_country/src * todo in dbip_download.yaml * condition for new branch generated-source * fixing condition for generated-source branch * fix generated-source branch name in condition * increse standard timeout milis const * manual trigger and debugging flags to runs * use variable to store git ls-remote command * add git fetch before checkout * fix workflow for nonexistent branch * fixing edgecases on nonexistent branch and no git changes * change neverssl to different web * Master gh 580 b dbip download workflow (#649) * final touch for dbip workflow * git pull before ci/all.sh --------- Co-authored-by: FinsaasGH <[email protected]> Co-authored-by: FinsaasGH <[email protected]> Co-authored-by: Dan Wiebe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.