-
Notifications
You must be signed in to change notification settings - Fork 6
Migrate project to uv #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
==========================================
- Coverage 88.28% 88.04% -0.25%
==========================================
Files 152 153 +1
Lines 6207 6224 +17
==========================================
Hits 5480 5480
- Misses 727 744 +17
🚀 New features to boost your workflow:
|
TheStrgamer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, tried it out locally and it was very easy to set up.
Maybe look into why codecov fails, but otherwise it's good
Ah yes, it's because of my changes in |
A more accurate name.
The next commit will migrate the project to use uv, which creates a `.venv` folder *inside* the repo folder by default. This commit mainly prevents `compilemessages` from processing every single `.po` file inside that `.venv` folder.
Also removed the `test-results` job (added in b833efd) as it's not needed now that we don't use `strategy.matrix` anymore to run the tests. Also changed Dependabot's update schedule for our Python dependencies from daily to weekly, which is probably more manageable for us. Also upgraded `actions/checkout` and `actions/setup-python`, which didn't have any breaking changes for us.
45b47b0 to
4e49ae3
Compare
Proposed changes
4e49ae3 introduces the following practical changes, among other things:
requirements[...].txtfiles intopyproject.toml, which is the more modern way of configuring a project's dependencies[tool.uv.sources]inpyproject.toml, removing the need to provide instructions for installingpython-ldapon Windows in the READMEuv run manage.py ...(instead ofpython manage.py ...)Also:
compilemessagesfrom processing files outside thesrcfolder (72f7d9c)Review guidance
Try installing the requirements using uv locally, and comment any feedback you have on the process 🙂
Deployment notes
Must update the deployment scripts on the prod server to use uv.
Checklist
(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)
makemigrations,makemessagesandcompilemessages