Skip to content

chore: add uv for python sdk #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 17, 2025
Merged

chore: add uv for python sdk #33

merged 9 commits into from
Jul 17, 2025

Conversation

juliette0704
Copy link
Contributor

@juliette0704 juliette0704 commented Jul 8, 2025

Description

This PR replaces 'pip' with 'uv' for managing development dependencies.
These changes introduce a faster and more reproducible development environment using uv.

Checklist

  • I have run the tests locally with make install-dev and make test
  • I have updated the README.md if my changes affected it
  • I have updated the package version in linkup/_version.py if I plan on creating a new release

@juliette0704 juliette0704 marked this pull request as ready for review July 8, 2025 11:48
@juliette0704 juliette0704 marked this pull request as draft July 8, 2025 11:49
@juliette0704 juliette0704 marked this pull request as ready for review July 8, 2025 11:49
@juliette0704 juliette0704 requested a review from cjumel July 9, 2025 08:05
@cjumel cjumel mentioned this pull request Jul 10, 2025
3 tasks
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some remarks and questions, but we're pretty much there. 🙂
Have you done any test of any kind, to validate your changes? This will break the current release workflow I guess, so we'll have to tackle your other PR after this one (at least before any new fix/feature)

@juliette0704 juliette0704 requested a review from cjumel July 15, 2025 09:00
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two very small remarks to polish things up 😇

@juliette0704
Copy link
Contributor Author

[tool.hatch.build.targets.wheel]
packages = ["src/linkup"]

Is used because the name of the package is just linkup and the name in the pyproject is "linkup_sdk"

@juliette0704 juliette0704 requested a review from cjumel July 15, 2025 14:58
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! ✌️

@juliette0704 juliette0704 merged commit 2fb5984 into main Jul 17, 2025
2 checks passed
@juliette0704 juliette0704 deleted the chore/switch_pip_to_uv branch July 17, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants