Changes to the test function #737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures on train end is called even if early stopping is applied
4 tasks
Borda
added
feature
Contributor
|
@HarshSharma12 @Borda is this still active? |
Borda
requested changes
Feb 14, 2020
Collaborator
Borda
left a comment
Borda
left a comment
There was a problem hiding this comment.
there is no need to close the progress bar?
| assert result == 1, 'amp + ddp model failed to complete' | ||
|
|
||
| if early_stop: | ||
| assert trainer.current_epoch >= trainer.min_epochs, 'amp + ddp model failed to complete' |
Collaborator
There was a problem hiding this comment.
rather make is raise an error
Borda
changed the title
Collaborator
|
@HarshSharma12 may you rebase, pls? |
Member
|
@Borda @williamFalcon @HarshSharma12 I had a look at rebasing this - the issue seems to have been fixed by #856 - see here I vote for closing this PR and the associated issue |
Collaborator
|
Ok, closing this... anyway very thanks @HarshSharma12 for your help and looking forward to your future help 🤖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #657. Overrides PR #726
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃