Skip to content

Conversation

@haossr
Copy link
Contributor

@haossr haossr commented Dec 13, 2019

What does this PR do?

Fixes #600 .
Add map_location to both loading functions.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

🙃

Copy link
Contributor

@jeffling jeffling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeffling
Copy link
Contributor

Weird, this was already in the docstring? :)
'

@haossr
Copy link
Contributor Author

haossr commented Dec 13, 2019

Yes. wired to me.

@haossr
Copy link
Contributor Author

haossr commented Dec 14, 2019

Someone help to merge?

@williamFalcon williamFalcon merged commit ca73b70 into Lightning-AI:master Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

map_location hasn't been implemented in load_from_checkpoint

3 participants