Write progress bar to stdout #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested changes
Nov 20, 2019
Collaborator
Borda
left a comment
Borda
left a comment
There was a problem hiding this comment.
I would open a discussion about the output, but I personally do not like having progress bar in stdout since it will interfere with any other logs...
Contributor
Author
|
Yeah that's fair. Happy to discuss more. Do you think having a trainer parameter that allows you to specify the output file would be okay? Did you want me to start an issue or discuss here? |
Collaborator
|
Heh... :-D |
|
Sorry to revive an old thread, but I think it's much more sensible to write the tqdm output to stderr. This way, we can redirect the training script output to a log file without cluttering it with tqdm progress bars. You can always redirect stderr to stdout in the shell itself if writing tqdm progress bars to stdout is absolutely needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default tqdm writes the progress bar to stderr. This PR changes the default to write to stdout, which is more sensible.