Minor imports cleaning #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
the test is passing, but somehow the check is not updated... @williamFalcon |
Contributor
|
Thanks for the PR. As I've mentioned before, I want to avoid relative imports. Please change to absolute imports and I can review again. |
Collaborator
Author
|
Sorry, completely forgot about the relative imports... |
Contributor
|
In addition, added a significant refactor to help avoid conflicts with multiple PRs and for clarity. Feel free to make the header changes there! |
* drop unused imports
Collaborator
Author
|
I would stay now with the minor cleansing so the PR is not so large... |
This was referenced Nov 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some minor code cleaning and switching to relative imports inside the package