-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix LightningCLI loading of hyperparameters from ckpt_path failing for subclass model mode #21246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SkafteNicki
merged 6 commits into
Lightning-AI:master
from
mauvilsa:cli-ckpt-hparams-subclass-mode
Sep 29, 2025
Merged
Fix LightningCLI loading of hyperparameters from ckpt_path failing for subclass model mode #21246
SkafteNicki
merged 6 commits into
Lightning-AI:master
from
mauvilsa:cli-ckpt-hparams-subclass-mode
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r subclass model mode
7 tasks
Borda
approved these changes
Sep 24, 2025
SkafteNicki
reviewed
Sep 24, 2025
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
SkafteNicki
approved these changes
Sep 24, 2025
ethanwharris
approved these changes
Sep 25, 2025
Contributor
|
Looks like this didn't make it into 2.5.6. Will there be a 2.5.7 or will 2.6.0 be next? |
Collaborator
|
Hi @adamjstewart, We will probably do 2.6.0 early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes torchgeo/torchgeo#2995
Maybe also fixes mehta-lab/VisCy#291
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21246.org.readthedocs.build/en/21246/