-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Explicitly enable grad in closure #18268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
reviewed
Aug 10, 2023
carmocca
approved these changes
Aug 10, 2023
Borda
approved these changes
Aug 10, 2023
for more information, see https://pre-commit.ci
awaelchli
approved these changes
Aug 10, 2023
Contributor
|
Thanks @0x404 for jumping on this so quickly. Great improvement. |
This was referenced Aug 10, 2023
Borda
pushed a commit
that referenced
this pull request
Aug 14, 2023
Co-authored-by: awaelchli <[email protected]> (cherry picked from commit b88b8b3)
lexierule
pushed a commit
that referenced
this pull request
Aug 14, 2023
Co-authored-by: awaelchli <[email protected]> (cherry picked from commit b88b8b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
community
This PR is from the community
optimization
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using optimizers from certain third-party libraries (such as Hugging Face's AdamW), their
optimizer.stepis decorated withtorch.no_grad. However, Lightning encapsulates hooks liketraining_stepandbackwardwithin a closure, which is executed duringoptimizer.step. This results in calculations withintraining_stepthat rely on gradients not having access to gradients.To address this issue, the
Closure.closureis decorated withtorch.enable_grad. This ensures that gradients can be computed correctly withinoptimizer.step, while the remaining parts of the optimizer can still benefit from theno_gradcontext.Fixes #18254
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist