Skip to content

Remove unnecessary check #17788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
awaelchli merged 5 commits into from
Jun 12, 2023
Merged

Remove unnecessary check #17788

awaelchli merged 5 commits into from
Jun 12, 2023

Conversation

@jerome-habana
Copy link
Contributor

@jerome-habana jerome-habana commented Jun 8, 2023

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 8, 2023
@Borda Borda added this to the 2.0.x milestone Jun 9, 2023
@Borda Borda marked this pull request as ready for review June 9, 2023 11:16
@mergify mergify bot added the ready PRs ready to be merged label Jun 9, 2023
@Borda Borda enabled auto-merge (squash) June 9, 2023 11:57
auto-merge was automatically disabled June 12, 2023 02:43

Head branch was pushed to by a user without write access

@awaelchli awaelchli enabled auto-merge (squash) June 12, 2023 09:15
@awaelchli awaelchli merged commit e4a3be7 into Lightning-AI:master Jun 12, 2023
Borda pushed a commit that referenced this pull request Jun 13, 2023
@jerome-habana @pre-commit-ci @Borda
Remove unnecessary check (#17788)
b215e13 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit e4a3be7)
lantiga pushed a commit that referenced this pull request Jun 22, 2023
@jerome-habana @pre-commit-ci @lantiga
Remove unnecessary check (#17788)
68acdbe 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit e4a3be7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fabric lightning.fabric.Fabric ready PRs ready to be merged

Projects

None yet

Milestone

2.0.x

Development

Successfully merging this pull request may close these issues.

4 participants

@jerome-habana @awaelchli @Borda @carmocca