Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 25, 2022

What does this PR do?

Fixes #15180

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @awaelchli @ananthsub @ninginthecloud @rohitgr7 @otaj

@rohitgr7 rohitgr7 added bug Something isn't working checkpointing Related to checkpointing labels Oct 25, 2022
@rohitgr7 rohitgr7 added this to the v1.8.x milestone Oct 25, 2022
@rohitgr7 rohitgr7 self-assigned this Oct 25, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 25, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review October 25, 2022 13:50
@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2022
@carmocca carmocca assigned carmocca and unassigned rohitgr7 Nov 7, 2022
@carmocca carmocca added feature Is an improvement or enhancement callback: model checkpoint and removed bug Something isn't working checkpointing Related to checkpointing labels Nov 8, 2022
@carmocca carmocca modified the milestones: v1.8.x, v1.9 Nov 8, 2022
@carmocca carmocca enabled auto-merge (squash) November 8, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback: model checkpoint feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

ModelCheckpoint not working when giving unexpected arg to Trainer

4 participants