Skip to content

Setup: add requirement freeze for next major version #14480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 5, 2022
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 31, 2022

What does this PR do?

implement freezing version for next major requirement release

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added release app (removed) Generic label for Lightning App package labels Aug 31, 2022
@Borda Borda added this to the app:0.6 milestone Aug 31, 2022
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Aug 31, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #14480 (695e220) into master (e5395de) will increase coverage by 23%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #14480     +/-   ##
=========================================
+ Coverage      63%      86%    +23%     
=========================================
  Files         346      338      -8     
  Lines       26967    26837    -130     
=========================================
+ Hits        17079    23095   +6016     
+ Misses       9888     3742   -6146     

@Borda Borda self-assigned this Sep 1, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 2, 2022
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR conflicts with #13912, which I feel would make this much easier if it was landed.

It would be nice if you could help me there with the CI failures that block it.

Additionally, can you update the PR title before merging?

Approving to unblock, but I would like to see #13912 be merged too

@Borda
Copy link
Member Author

Borda commented Sep 2, 2022

This PR conflicts with #13912, which I feel would make this much easier if it was landed.

This is needed for the 0.6 release on Monday

It would be nice if you could help me there with the CI failures that block it.

yes, happy to help :)

@Borda Borda changed the title Req/freeze major Setup: add requirement freeze for next major version Sep 2, 2022
@Borda Borda enabled auto-merge (squash) September 5, 2022 17:57
@Borda Borda merged commit ea3d62d into master Sep 5, 2022
@Borda Borda deleted the req/freeze_major branch September 5, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants