Skip to content

[CLI] Cluster logs CLI improvements: new log labels + test coverage increasing #14459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2022

Conversation

dmitsf
Copy link
Member

@dmitsf dmitsf commented Aug 30, 2022

What does this PR do?

The PR just adds two things to the PR on cluster logs, in order to make small improvements:

  • More CLI tests on getting cluster logs command;
  • Few more log labels to be parsed.

I think there are no significant changes for our changelog.

Does your PR introduce any breaking changes? If yes, please list them.

No, it doesn't.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @akihironitta

@dmitsf dmitsf self-assigned this Aug 30, 2022
@dmitsf dmitsf marked this pull request as ready for review August 30, 2022 18:41
@dmitsf dmitsf changed the title [CLI] Cluster logs CLI improvements [CLI] Cluster logs CLI improvements: new log label + test coverage increasing Aug 30, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 30, 2022
@awaelchli awaelchli modified the milestones: app:0.6, app:0.7 Aug 30, 2022
@dmitsf dmitsf force-pushed the dmitsf/improvings_on_cluster_logs branch 2 times, most recently from 5a58b9e to 33c97ef Compare August 30, 2022 20:41
@mergify mergify bot added the ready PRs ready to be merged label Aug 30, 2022
@dmitsf dmitsf force-pushed the dmitsf/improvings_on_cluster_logs branch from 33c97ef to c0780c6 Compare August 30, 2022 21:13
@dmitsf dmitsf changed the title [CLI] Cluster logs CLI improvements: new log label + test coverage increasing [CLI] Cluster logs CLI improvements: new log labels + test coverage increasing Aug 31, 2022
@dmitsf dmitsf merged commit 9372981 into master Aug 31, 2022
@dmitsf dmitsf deleted the dmitsf/improvings_on_cluster_logs branch August 31, 2022 02:22
@Borda Borda modified the milestones: app:0.7, app:0.6 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants