Skip to content

Fix regression on default value for find_unused_parameters #14095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 9, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 8, 2022

What does this PR do?

Fixes #14089

The change was unintentionally introduced in #13405, #13744. Tests have been added that fail on master.

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @justusschock @kaushikb11 @awaelchli @akihironitta

@awaelchli awaelchli added bug Something isn't working priority: 0 High priority task strategy: ddp spawn labels Aug 8, 2022
@awaelchli awaelchli added this to the pl:1.7.x milestone Aug 8, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 8, 2022
@awaelchli awaelchli changed the title Bugfix/find unused Fix regression on default value for find_unused_parameters Aug 8, 2022
@awaelchli awaelchli marked this pull request as ready for review August 8, 2022 17:55
@awaelchli awaelchli self-assigned this Aug 8, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 9, 2022
@kaushikb11 kaushikb11 merged commit 0cfc53d into master Aug 9, 2022
@kaushikb11 kaushikb11 deleted the bugfix/find-unused branch August 9, 2022 08:26
@carmocca
Copy link
Contributor

carmocca commented Aug 9, 2022

@awaelchli This was merged with Windows job failures. Can you fix them?

@awaelchli
Copy link
Contributor Author

Yes, I didn't notice.
The logic is correct. The test just needs to be skipped on Windows.

@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
@mergify mergify bot removed the ready PRs ready to be merged label Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package priority: 0 High priority task strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

find_unused_parameters forced to False for ddp_{spawn,fork}
5 participants