Skip to content

Set default strategy to ddp_fork in interactive environments #13746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 20, 2022

What does this PR do?

Follow up to #13744 and #13405.

This PR makes it so that in Jupyter notebooks, you only need two specify

Trainer(devices=2)

instead of

Trainer(strategy="ddp_notebook", devices=2)

similar to the TPU strategy being auto-selected when accelerator="tpu".

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 20, 2022
@awaelchli awaelchli added feature Is an improvement or enhancement strategy: ddp spawn labels Jul 20, 2022
@awaelchli awaelchli added this to the pl:1.7 milestone Jul 20, 2022
@awaelchli awaelchli mentioned this pull request Jul 20, 2022
12 tasks
@awaelchli awaelchli force-pushed the feature/ddp-fork2-autodetect branch from 348e61a to b14786e Compare July 22, 2022 16:33
@awaelchli awaelchli changed the base branch from feature/ddp-fork2-notebook to master July 22, 2022 16:33
@awaelchli awaelchli marked this pull request as ready for review July 22, 2022 16:34
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@mergify mergify bot added the ready PRs ready to be merged label Jul 22, 2022
@awaelchli awaelchli enabled auto-merge (squash) July 22, 2022 19:01
@awaelchli awaelchli merged commit f6f06d4 into master Jul 22, 2022
@awaelchli awaelchli deleted the feature/ddp-fork2-autodetect branch July 22, 2022 19:34
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants