Include app templates to the lightning and app packages #13731

manskx · 2022-07-19T10:14:55Z

What does this PR do?

Adding app templates to the lightning package.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

adam-lightning · 2022-07-19T11:24:18Z

Was the issue regarding missing templates in release package finally created? Just wondering if we can link this PR to it.

Borda · 2022-07-19T11:43:46Z

Was the issue regarding missing templates in release package finally created? Just wondering if we can link this PR to it.

this issue is related to the last release 0.5.2

williamFalcon · 2022-07-19T12:06:15Z

@manskx
what templates are these?

manskx · 2022-07-19T12:16:08Z

@manskx what templates are these?

@williamFalcon these are the templates used to create a lightning app from the CLI, e.g. init pl-app ./train_script.py or lightning init react-ui

williamFalcon · 2022-07-19T12:25:00Z

these shouldn’t live in this repo… this template is specific to the lightning app repo, it should live there. We don’t need to bloat everyone’s install with unnecessary files.

cc @lantiga

manskx · 2022-07-19T12:49:03Z

these shouldn’t live in this repo… this template is specific to the lightning app repo, it should live there. We don’t need to bloat everyone’s install with unnecessary files.

cc @lantiga

@awaelchli as far as I remember, these templates were added for a reason ?

awaelchli · 2022-07-19T12:52:38Z

Yes, the templates should be included of course. Otherwise we can't use them from the CLI. This is just the code that we added to the app repo.

luca-medeiros · 2022-07-20T04:23:43Z

The related issue #13745

lantiga · 2022-07-20T09:21:11Z

@williamFalcon I agree with keeping templates independent, however in order to do so properly we need to take care of cross-version compatibility. @manskx will kick off a GH issue shortly so we can figure out the details.

For the time being I'd strongly suggest to still expose the templates at the package level following this PR, so we fix the experience for users.

manskx · 2022-07-20T12:13:03Z

@williamFalcon I agree with keeping templates independent, however in order to do so properly we need to take care of cross-version compatibility. @manskx will kick off a GH issue shortly so we can figure out the details.

For the time being I'd strongly suggest to still expose the templates at the package level following this PR, so we fix the experience for users.

Created the issue here: #13757

I am going to enable auto-merge this to fix the package now.

* Include app templates to the package Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>

* Rename GPUAccelerator to CUDAAccelerator * Add back GPUAccelerator and deprecate it * Remove temporary registration * accelerator connector reroute * accelerator_connector tests * update enums * lite support + tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * typo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move "gpu" support up before actual accelerator flag checks * Stupid arguments * fix tests * change exception type * fix registry test * pre-commit * CI: debug HPU flow (#13419) * Update the hpu-tests.yml to pull docker from vault * fire & sudo * habana-gaudi-hpus * Check the driver status on gaudi server (#13718) Co-authored-by: arao <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akarsha Rao <[email protected]> * Update typing-extensions requirement from <4.2.1,>=4.0.0 to >=4.0.0,<4.3.1 in /requirements (#13529) Update typing-extensions requirement in /requirements Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.0.0...4.3.0) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit suggestions (#13540) updates: - [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [FIX] Native FSDP precision + tests (#12985) * Simplify fetching's loader types (#13111) * Include app templates to the lightning and app packages (#13731) * Include app templates to the package Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> * Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py (#13617) Co-authored-by: Carlos Mocholí <[email protected]> * Fix typos initialize in docs (#13557) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> * Fix main progress bar counter when `val_check_interval=int` and `check_val_every_n_epoch=None` (#12832) * Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` (#13688) Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> * Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` (#13691) Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: otaj <[email protected]> * fix mypy errors for loggers/wandb.py (#13483) Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]> * Fix gatekeeper minimum check (#13769) * changelog * changelog * fix order * move up again * add missing test Co-authored-by: rohitgr7 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: arao <[email protected]> Co-authored-by: Akarsha Rao <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Naren <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Mansy <[email protected]> Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Lee Jungwon <[email protected]> Co-authored-by: Nathaniel D'Amours <[email protected]> Co-authored-by: Justin Goheen <[email protected]> Co-authored-by: otaj <[email protected]> Co-authored-by: Gautier Dagan <[email protected]> Co-authored-by: Akihiro Nitta <[email protected]>

* Include app templates to the package Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit ca1917e)

mansy added 2 commits July 19, 2022 12:14

Include app templates to the package

abea463

Include app templates to the full package

bf40e7c

manskx marked this pull request as ready for review July 19, 2022 11:08

manskx requested review from tchaton, awaelchli, hhsecond, williamFalcon, Borda, SeanNaren, carmocca, justusschock, kaushikb11 and rohitgr7 as code owners July 19, 2022 11:09

manskx changed the title ~~Include app templates to the package~~ Include app templates to the lightning and app packages Jul 19, 2022

rohitgr7 approved these changes Jul 19, 2022

View reviewed changes

manskx added priority: 0 High priority task app (removed) Generic label for Lightning App package app:cli labels Jul 19, 2022

manskx added this to the app:0.5.x milestone Jul 19, 2022

Borda approved these changes Jul 19, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jul 19, 2022

williamFalcon closed this Jul 19, 2022

lantiga reopened this Jul 20, 2022

manskx mentioned this pull request Jul 20, 2022

Lightning init [app/pl-app] issues #13745

Closed

awaelchli approved these changes Jul 20, 2022

View reviewed changes

Merge branch 'master' into lai2-9840-lightning-pl-app-doesnt-work

e266357

manskx merged commit ca1917e into master Jul 20, 2022

manskx deleted the lai2-9840-lightning-pl-app-doesnt-work branch July 20, 2022 13:59

justusschock pushed a commit that referenced this pull request Jul 21, 2022

Include app templates to the lightning and app packages (#13731)

3129d97

* Include app templates to the package Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>

awaelchli mentioned this pull request Jul 25, 2022

[App] Introduce Commands #13602

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Include app templates to the lightning and app packages #13731

Include app templates to the lightning and app packages #13731

Uh oh!

manskx commented Jul 19, 2022 •

edited by github-actions bot

Loading

Uh oh!

adam-lightning commented Jul 19, 2022

Uh oh!

Borda commented Jul 19, 2022

Uh oh!

williamFalcon commented Jul 19, 2022

Uh oh!

manskx commented Jul 19, 2022

Uh oh!

williamFalcon commented Jul 19, 2022 •

edited

Loading

Uh oh!

manskx commented Jul 19, 2022

Uh oh!

awaelchli commented Jul 19, 2022

Uh oh!

luca-medeiros commented Jul 20, 2022

Uh oh!

lantiga commented Jul 20, 2022

Uh oh!

manskx commented Jul 20, 2022

Uh oh!

Uh oh!

Include app templates to the lightning and app packages #13731

Include app templates to the lightning and app packages #13731

Uh oh!

Conversation

manskx commented Jul 19, 2022 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

Uh oh!

adam-lightning commented Jul 19, 2022

Uh oh!

Borda commented Jul 19, 2022

Uh oh!

williamFalcon commented Jul 19, 2022

Uh oh!

manskx commented Jul 19, 2022

Uh oh!

williamFalcon commented Jul 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manskx commented Jul 19, 2022

Uh oh!

awaelchli commented Jul 19, 2022

Uh oh!

luca-medeiros commented Jul 20, 2022

Uh oh!

lantiga commented Jul 20, 2022

Uh oh!

manskx commented Jul 20, 2022

Uh oh!

Uh oh!

manskx commented Jul 19, 2022 •

edited by github-actions bot

Loading

williamFalcon commented Jul 19, 2022 •

edited

Loading