Skip to content

Move deepspeed summary test to correct folder #13478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 1, 2022

What does this PR do?

In #13427 a model summary was added in utilities, but the tests for it were mistakenly added to the callbacks folder.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @justusschock @awaelchli @rohitgr7 @SeanNaren @akihironitta @Borda

@mergify mergify bot added the ready PRs ready to be merged label Jul 1, 2022
@rohitgr7 rohitgr7 enabled auto-merge (squash) July 1, 2022 08:29
@rohitgr7 rohitgr7 merged commit a80354e into master Jul 1, 2022
@rohitgr7 rohitgr7 deleted the tests/deepspeed-summary branch July 1, 2022 08:47
jerome-habana pushed a commit to jerome-habana/lightning that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants