Skip to content

Conversation

k223kim
Copy link
Collaborator

@k223kim k223kim commented Aug 8, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Users will have autocompletion for the models that Lightning supports.

Demo: https://www.loom.com/share/b11ef9a82196458094c80c85de7911c3?sid=6a3c8101-6b6e-4233-87c0-a2cbf24923a7

Screenshot:
image

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@k223kim k223kim changed the title K223kim/auto completion models feat: auto completion models Aug 8, 2025
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 30.30303% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 84%. Comparing base (472143a) to head (1644ef5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #41   +/-   ##
==================================
- Coverage    89%   84%   -4%     
==================================
  Files         6     8    +2     
  Lines       400   432   +32     
==================================
+ Hits        355   364    +9     
- Misses       45    68   +23     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@k223kim k223kim marked this pull request as ready for review August 8, 2025 04:18
@k223kim k223kim changed the title feat: auto completion models feat: support auto completion of models Aug 8, 2025
@justusschock justusschock merged commit cf437e6 into main Aug 8, 2025
31 checks passed
@justusschock justusschock deleted the k223kim/auto-completion-models branch August 8, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants