Skip to content

create_addon script doesn't handle incompatible addons well #9917

@vpeter4

Description

@vpeter4
$ ./scripts/create_addon pvr.iptvsimple -argononecontrol
argononecontrol: Incompatible arch: "x86_64" not in [ aarch64 ]
ERROR: no addons matched for filter argononecontrol
For more information type: ./scripts/create_addon --help
*********** FAILED COMMAND ***********
addons_drop+=" $(get_addons ${1:1})"
**************************************

I assume above command should work just fine and only pvr.iptvsimple addon should be build? And argononecontrol addon just skipped.

And why even do some checks for addon which we don't want to build anyway? Why not just

diff --git a/scripts/create_addon b/scripts/create_addon
index a725842863..a2b56e556b 100755
--- a/scripts/create_addon
+++ b/scripts/create_addon
@@ -162,7 +162,7 @@ while [ $# -gt 0 ]; do
       usage 1
       ;;
     -*)
-      addons_drop+=" $(get_addons ${1:1})"
+      addons_drop+=" ${1:1}"
       ;;
     *)
       addons+=" $(get_addons ${1})"
 

Update: Issue ignored for months. Seems if no one else see it it or be affected then doesn't exist :(

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions