Skip to content

GitHub Actions: Python versions must not be quoted #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 20, 2023

Pytest logs currently contain:

  File "/home/runner/work/bagit-python/bagit-python/bagit.py", line 1119, in get_hashers
    "Unable to continue: hashlib does not support any of the requested algorithms!"
ValueError: Unable to continue: hashlib does not support any of the requested algorithms!

@cclauss cclauss changed the title GitHub Actions: Python 3.7 is no longer on ubuntu-latest GitHub Actions: Python versions must not be quoted Mar 20, 2023
@acdha
Copy link
Member

acdha commented Mar 23, 2023

The Python 3.7 part is making me wonder if we should switch to the official Python images instead.

@cclauss
Copy link
Contributor Author

cclauss commented Mar 24, 2023

https://github.com/LibraryOfCongress/bagit-python/actions/runs/4471750912/jobs/7857032424

corresponds with

https://devguide.python.org/versions

Python 3.7 reaches end-of-life in ~3 months so you can choose to test/support it or drop support early.

Successfully set up CPython (3.7.16)
Successfully set up CPython (3.8.16)
Successfully set up CPython (3.9.16)
Successfully set up CPython (3.10.10)
Successfully set up CPython (3.11.2)

@acdha
Copy link
Member

acdha commented Mar 24, 2023

https://github.com/LibraryOfCongress/bagit-python/actions/runs/4471750912/jobs/7857032424

corresponds with

https://devguide.python.org/versions

Python 3.7 reaches end-of-life in ~3 months so you can choose to test/support it or drop support early.

Successfully set up CPython (3.7.16)
Successfully set up CPython (3.8.16)
Successfully set up CPython (3.9.16)
Successfully set up CPython (3.10.10)
Successfully set up CPython (3.11.2)

For most tools, we tend to track the support lifetime of common operating systems — for example, RHEL 7 and other distributions of that vintage have Python 3.7 as the default and that's fully supported for a year past when the core Python developers discontinue support.

This avoids an error when the msgfmt utility is run to process translations
@acdha acdha merged commit e831c74 into LibraryOfCongress:master Mar 24, 2023
@cclauss cclauss deleted the patch-1 branch March 24, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants