Skip to content

assign values to argument namespace instead of parser #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2018
Merged

assign values to argument namespace instead of parser #108

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f46aafe
assign bag_info from arguments to namespace instead of parser
Apr 30, 2018
70c97e8
always set bag_info on namespace
Apr 30, 2018
55071cf
remove useless default values from namespace
Apr 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions bagit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,15 +1442,15 @@ def force_unicode_py2(s):

class BagArgumentParser(argparse.ArgumentParser):
def __init__(self, *args, **kwargs):
self.bag_info = {}
argparse.ArgumentParser.__init__(self, *args, **kwargs)
self.set_defaults(bag_info={})


class BagHeaderAction(argparse.Action):
def __call__(self, parser, _, values, option_string=None):
def __call__(self, parser, namespace, values, option_string=None):
opt = option_string.lstrip("--")
opt_caps = "-".join([o.capitalize() for o in opt.split("-")])
parser.bag_info[opt_caps] = values
namespace.bag_info[opt_caps] = values


def _make_parser():
Expand Down Expand Up @@ -1522,7 +1522,7 @@ def _make_parser():
metadata_args = parser.add_argument_group(_("Optional Bag Metadata"))
for header in STANDARD_BAG_INFO_HEADERS:
metadata_args.add_argument(
"--%s" % header.lower(), type=str, action=BagHeaderAction
"--%s" % header.lower(), type=str, action=BagHeaderAction, default=argparse.SUPPRESS
)

parser.add_argument(
Expand Down Expand Up @@ -1593,7 +1593,7 @@ def main():
try:
make_bag(
bag_dir,
bag_info=parser.bag_info,
bag_info=args.bag_info,
processes=args.processes,
checksums=args.checksums,
)
Expand Down