[2.x] Expose attemptWhen method#80
Merged
DarkGhostHunter merged 1 commit intoLaragear:2.xfrom May 22, 2024
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #80 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 157 158 +1
===========================================
Files 20 20
Lines 444 446 +2
===========================================
+ Hits 444 446 +2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
This feature branch adds and exposes the
attemptWhenmethod to/on theTwoFactorLoginHelperandAuth2FA. This allows projects that need to pass their own callbacks for pre-login checks to integrate with this package.This will not break backward compatibility since it merely adds a new method.
Code samples
This PR simply adds a new method matching the signature of the
SessionGuard's method:And changes the current
attemptmethod to call this new method passingnullas$callbacks:This approach seems cleaner than simply duplicating the code (which is actually what the
SessionGuarddoes).