Skip to content

[1.2] Add Laravel 10 Support#41

Merged
DarkGhostHunter merged 6 commits intoLaragear:1.xfrom
TFSThiagoBR98:1.x
Feb 15, 2023
Merged

[1.2] Add Laravel 10 Support#41
DarkGhostHunter merged 6 commits intoLaragear:1.xfrom
TFSThiagoBR98:1.x

Conversation

@TFSThiagoBR98
Copy link
Copy Markdown
Contributor

@TFSThiagoBR98 TFSThiagoBR98 commented Feb 14, 2023

Description

Add support for Laravel 10

@TFSThiagoBR98 TFSThiagoBR98 mentioned this pull request Feb 14, 2023
4 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2023

Codecov Report

Base: 99.75% // Head: 99.75% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3b9e706) compared to base (1792c33).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3b9e706 differs from pull request most recent head 335f3ff. Consider uploading reports for the commit 335f3ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x      #41   +/-   ##
=========================================
  Coverage     99.75%   99.75%           
  Complexity      138      138           
=========================================
  Files            18       18           
  Lines           405      406    +1     
=========================================
+ Hits            404      405    +1     
  Misses            1        1           
Impacted Files Coverage Δ
src/TwoFactorServiceProvider.php 100.00% <ø> (ø)
src/TwoFactorAuthentication.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@it-can
Copy link
Copy Markdown
Contributor

it-can commented Feb 15, 2023

yes please! @DarkGhostHunter

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@TFSThiagoBR98
Copy link
Copy Markdown
Contributor Author

@DarkGhostHunter CI fixed

@DarkGhostHunter
Copy link
Copy Markdown
Contributor

Support will be done for the oldest PHP stable version (8.1 currently). From there, we can devise which Laravel versions to support.

In this case, it's good: PHP 8.1 and Laravel 9. Next year it will be PHP 8.2 and Laravel 10, which will introduce breaking changes.

@DarkGhostHunter DarkGhostHunter merged commit 50164ab into Laragear:1.x Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants