Skip to content

PLT-2761 - Prevent ID change for initial nodes and fix edge ids #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025

Conversation

paulnoirel
Copy link
Contributor

Description

The current PR fixes the following problems:

  • Methods reset_to_initial_nodes() and clone_from_worklow() modify the ID of InitialLabelingNode and InitialReworkNode breaking workflows.

  • Compared to the UI, edge IDs have a random format.

Fixes # (issue)
PLT-2761)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@paulnoirel paulnoirel merged commit 43590a9 into develop Jul 9, 2025
57 of 64 checks passed
@paulnoirel paulnoirel deleted the pno/PLT-2761-fix-workflow-initial-nodes-ids branch July 9, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants