Skip to content

Added support for AppConfig notation in INSTALLED_APPS settings #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 19, 2018
Merged

Added support for AppConfig notation in INSTALLED_APPS settings #10

merged 6 commits into from
Feb 19, 2018

Conversation

yamijuan
Copy link
Member

closes #9

@yamijuan yamijuan requested a review from MiltonLn February 17, 2018 00:04
MiltonLn
MiltonLn requested changes Feb 17, 2018
View reviewed changes
menu_generator/utils.py Outdated
return app_path
else:
app_split = app_path.split('.')
new_app = '.'.join(app_split[:len(app_split) - 2])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this line by:

new_app = '.'.join(app_split[-2:])

@coveralls
Copy link

coveralls commented Feb 17, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 51

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 99.329%
Totals Coverage Status
Change from base Build 45: 0.05%
Covered Lines: 148
Relevant Lines: 149
💛 - Coveralls

@MiltonLn MiltonLn merged commit 70e6777 into LaLogiaDePython:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiltonLn MiltonLn MiltonLn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with menu in apps when AppConfig is referenced in INSTALLED_APPS
3 participants
@yamijuan @coveralls @MiltonLn