Allow PCAP_LIBRARY to be overridden at compile time

[lhoward]

This is useful for specifying the soname of libpcap as systems without development libraries installed may not have libpcap.so installed.

Fixes: #192

(Note: not tested yet.)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[christophe-calmejane]

2 things:

• I would only enable it for linux (especially not on macOS as the user might spend ours trying to figure out why it's not working anymore)
• We have to pass the option from cmake (explaining it's for linux, relative or absolute path)

[lhoward]

• I would only enable it for linux (especially not on macOS as the user might spend ours trying to figure out why it's not working anymore)

Potentially the same issue could occur on macOS I think (libpcap isn't shipped as part of Darwin though, is it?)

[christophe-calmejane]

• I would only enable it for linux (especially not on macOS as the user might spend ours trying to figure out why it's not working anymore)

Potentially the same issue could occur on macOS I think (libpcap isn't shipped as part of Darwin though, is it?)

It is shipped, and you actually have to use it, because of increasingly tight hardening on binaries that run on macOS, otherwise you get errors almost impossible to understand. That's the comment in the code for macOS.

[lhoward]

Are you sure it's shipped on Darwin? I just setup a new 15.6 machine yesterday and I can't find it in /usr/lib. Anyway, happy to make the change.

Also WireShark, PTP TrackHound, etc usually install their own version.

[christophe-calmejane]

I'm sure of nothing, but I never installed it :)
I've never heard any Hive user complaining it's not running due to missing pcap library, and I'm almost certain that at least one of them used it on an almost fresh computer.
But if you start hive on your fresh computer, it will show the path of the lib in the logs.

[lhoward]

I'm sure of nothing, but I never installed it :) I've never heard any Hive user complaining it's not running due to missing pcap library, and I'm almost certain that at least one of them used it on an almost fresh computer. But if you start hive on your fresh computer, it will show the path of the lib in the logs.

You're right, I was fooled as it is in the dyld shared cache, so there's no actual file in /usr/lib. I will make the suggested change.

[christophe-calmejane]

I will make the changes, namely add the compilation option (CMakeLists.txt, src/CMakeLists.txt) and a small explanation in README.md in the linux compilation section, and change the logic to override the value in the linux specific initialization of the .so

[lhoward]

Thank you, sorry, I've been swamped in other bugs.

[christophe-calmejane]

Ok, implemented