Skip to content

fix: use current Codex max threads setting - #51

Open
mitrilmad wants to merge 1 commit into
Kritt-ai:mainfrom
mitrilmad:fix/codex-max-threads-config
Open

fix: use current Codex max threads setting#51
mitrilmad wants to merge 1 commit into
Kritt-ai:mainfrom
mitrilmad:fix/codex-max-threads-config

Conversation

@mitrilmad

Copy link
Copy Markdown

What & why

Codex CLI rejects the obsolete agents.max_concurrent_threads_per_session config key. Use the current agents.max_threads key in both fresh and resumed Codex command construction, and update the command-shape regressions.

Type of change

  • fix — bug fix
  • feat — new feature
  • docs — documentation only
  • test
  • Breaking change

Affected components

  • engine

Verification

  • full engine suite: 293 passed
  • focused Codex command regressions: 3 passed
  • ruff check on changed files: pass
  • ruff format --check on changed files: pass
  • git diff --check: pass

The repository currently pins psycopg[binary]==3.3.4, which was unavailable from the configured package index. The full suite used Python 3.11 with psycopg[binary]==3.2.13; pytest remained at the pinned 9.1.1. No dependency file is changed by this PR.

Checklist

  • Conventional Commit
  • DCO signed off
  • Tests updated and passing
  • No secrets committed

Signed-off-by: mitrilmad <11910955+mitrilmad@users.noreply.github.com>
anupamjaiswall added a commit to anupamjaiswall/open-kritt-cli-only that referenced this pull request Aug 23, 2026
…ritt-ai#52,Kritt-ai#77,Kritt-ai#85)

- Kritt-ai#48 backend: validate scan workflow/post-script ids as positive DB ids
- Kritt-ai#49 backend: reject duplicate output-format keys (workflow + post-script)
- Kritt-ai#52 backend: atomic appendComments for vulnerability triage notes
- Kritt-ai#77 engine: disable Claude Code model/refusal fallback on OpenRouter
  (resolved against main's CLAUDE_OPENROUTER_MODEL_ENV_KEYS pinning)
- Kritt-ai#51 engine: codex agents.max_threads config key
- Kritt-ai#85 cli: Docker/Compose preflight checks in ./kritt start
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant