Skip to content

Make WS plugin installation for Ktor server more flexible #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Jul 15, 2025

Subsystem
kRPC

Problem Description
Ktor plugin installed WebSockets twice if there was already a plugin before

Solution
Fix it!

@Mr3zee Mr3zee requested a review from e5l July 15, 2025 12:16
@Mr3zee Mr3zee self-assigned this Jul 15, 2025
@Mr3zee Mr3zee added the bug Something isn't working label Jul 15, 2025
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e5l
Copy link
Member

e5l commented Jul 17, 2025

please log ktor issue as well

@Mr3zee
Copy link
Collaborator Author

Mr3zee commented Jul 17, 2025

@e5l no issue ob Ktor side, my issue description is a bit ambiguous, sorry

@Mr3zee Mr3zee merged commit f6f6c12 into main Jul 17, 2025
4 checks passed
@Mr3zee Mr3zee deleted the ktor-ws-plugin-server branch July 17, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants