Skip to content

Make KtorRpcClient inherit KrpcClient #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025
Merged

Make KtorRpcClient inherit KrpcClient #396

merged 1 commit into from
Jul 17, 2025

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Jul 14, 2025

Subsystem
kRPC

Problem Description
We had a weird inheritance chain in KtorRpcClient, which didn't reflect that it is KrpcClient, so there is no way to cal close(), for example, without casting

Solution
Fix it!

@Mr3zee Mr3zee requested a review from e5l July 14, 2025 17:28
@Mr3zee Mr3zee self-assigned this Jul 14, 2025
@Mr3zee Mr3zee added the bug Something isn't working label Jul 14, 2025
@Mr3zee Mr3zee mentioned this pull request Jul 15, 2025
@Mr3zee Mr3zee merged commit 25045d9 into main Jul 17, 2025
4 checks passed
@Mr3zee Mr3zee deleted the ktor-krpc-client-fix branch July 17, 2025 10:04
@Mr3zee Mr3zee mentioned this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants