Skip to content

Fix build config for for-ide builds #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

Mr3zee
Copy link
Collaborator

@Mr3zee Mr3zee commented Feb 14, 2025

Subsystem
Gradle

Problem Description
for-ide artifacts were built against wrong version of the compiler, which led to incompatibilities

Solution
Fix configs to build against proper compiler version, respecting kotlin-compiler param in libs.versions.toml

@Mr3zee Mr3zee added the infra Infrastructure changes (Gradle, CI, project setup, etc) label Feb 14, 2025
@Mr3zee Mr3zee requested a review from e5l February 14, 2025 01:00
@Mr3zee Mr3zee self-assigned this Feb 14, 2025
whenForIde {
compileOnly(libs.kotlin.compiler)
} otherwise {
compileOnly(libs.kotlin.compiler.embeddable)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency has been deprecated in the kgp. Could you tell me if we can be more specific here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embeddable is the proper dependency for compiler plugins, as embeddable runs during compilation process. Now, raw compiler runs in IDE, hence the difference

@Mr3zee Mr3zee merged commit 0b5d334 into main Feb 14, 2025
2 checks passed
@Mr3zee Mr3zee deleted the for-ide-build-config-fix branch February 14, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Infrastructure changes (Gradle, CI, project setup, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants