-
Notifications
You must be signed in to change notification settings - Fork 33
Description
Hello. First of all, thanks for the awesome work on this!
I wanted to bring up a minor issue regarding the naming convention used for the library classes. The official Kotlin coding conventions guide specifies the following:
When using an acronym as part of a declaration name, capitalize it if it consists of two letters (
IOStream
); capitalize only the first letter if it is longer (XmlFormatter
,HttpInputStream
).
(https://kotlinlang.org/docs/coding-conventions.html#choose-good-names)
Overall, the library is using capitalized RPC
everywhere. I think for the RPC
declaration it's ok, but RPCClient
, RPCServer
, for example, should actually be RpcClient
and RpcServer
.
Again, this is minor, but it would be nice to follow the official conventions. I can open a PR with this change if you all agree.