Skip to content

Let's review pending changes #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 82 commits into from
May 18, 2021
Merged

Let's review pending changes #79

merged 82 commits into from
May 18, 2021

Conversation

belyaev-mikhail
Copy link
Contributor

No description provided.

petukhovv and others added 30 commits July 27, 2020 17:52
@petukhovv
Pass webpack build mode through gradle parameters
3752890
@petukhovv
Replace hardcoded mode to defined by url's get parameter one
78516c8
@zarechenskiy
Turn Compatitiblity chapter into a paragraph
a484d2e
@zarechenskiy
Fix paragraph about Compatibility
c2b017c
@stasjas
exclude compatibility section to load tests
f1445ac
@Egorand @PetukhovVictor
Fix typo in Reload tests button label
ddf3529
@ice-phoenix
Change formal argument -> formal parameter to disambiguate even more
2d5a7ca
@ice-phoenix
Add a note about PRs should be based on develop branch
8875691
@belyaev-mikhail
Bare types sketch
d238f9c
@ice-phoenix
Some clarifications about data class generated function explicificati…
391cc92 
…on/inheritance
@ice-phoenix
Fix typo
fd4d3c3
@belyaev-mikhail
Some rewriting on the bare type syntax
f740a26
@ice-phoenix
Fix typo
f5168dc
@ice-phoenix
Some details of how val/var properties work (#59)
86b8a4b
@ice-phoenix
Add TODO about funky Kotlin script file scope
08c736a
@ice-phoenix
Add a note about only inner classes being allowed in object literals
3ad1613
@ice-phoenix
Fix typo
1733307
@ice-phoenix
Clarifications on where inner classes are and are not allowed
5c5762d
@ice-phoenix
Better wording
4c478b2
@belyaev-mikhail
kotlin.Annotation is an interface
79c093a
@belyaev-mikhail
Fix broken link
e935d1c
@belyaev-mikhail
Contracts draft
e18cc50
@belyaev-mikhail
Inline classes draft
71acc44
@ice-phoenix
First example for type capturing
7302377
@ice-phoenix
More type capturing examples
c5811dc
@ice-phoenix
Smart casts: change Direct assignments to Simple assignments
e71b05d
@ice-phoenix
Fixing Unicode problems in PDF
0870b5f
@stasjas
Fix sentence-finder-bar style in Dev mode
d35e0c2
@stasjas
Improve header bar style in dev mode
cf9a626
@stasjas
Disable kotlin core section link in toc
8be83b6
ice-phoenix and others added 23 commits January 26, 2021 16:30
@ice-phoenix
Fix for grammar testData dir copy
79b942e
@ice-phoenix
Add fresh antlrtree.txt files
71ae6d1
@ice-phoenix
Drop obsolete antlrtree.txt files after syncWithCompilerTests
7c2aab4
@belyaev-mikhail
Green grammar tests
044a042
@ice-phoenix
Add sealed interfaces and update when expression exhaustiveness rules
8f73578
@ice-phoenix
Fix GLB -> LUB in type decaying
ba9f417
@ice-phoenix
Add note about the least single common supertype in type approximation
d61db06
@ice-phoenix
Drop SVN dependency from grammar README.md
0cc23be
@belyaev-mikhail
Updates for 1.5: inline classes -> value classes
58fe6f2
@belyaev-mikhail
Updates for 1.5: value classes in grammar
83066e8
@belyaev-mikhail
Prepare for bintray EOL: remove most of bintray dependencies
4d983db
@belyaev-mikhail
Fix CI build
dcea4f1
@belyaev-mikhail
Fix test data for the grammar change
6730c24
@SmelJey
Add UnsignedLiteral to syntax.md
950e096
@SmelJey
Fix order of suffixes in UnsignedLiteral
a9e2849
@belyaev-mikhail
Merge pull request #72 from SmelJey/develop
254bdfc 
Add UnsignedLiteral to syntax.md
@belyaev-mikhail
Compound expansion sketch (see https://youtrack.jetbrains.com/issue/K…
eb8a999 
…T-45503)
@belyaev-mikhail
Merge remote-tracking branch 'origin/develop' into develop
f89e130
@androiddevnotes
Fix typo
b8f1382 
lever -> level
@ice-phoenix
Merge pull request #75 from awesome-kotlin/develop
b34ac3e 
Fix typo in README.md
@drieks
newlines are allowed in lineStringExpression closes #40 (#77)
10d95ba 
newlines are allowed in lineStringExpression closes #40
@ice-phoenix
Fill the missing parts about async programming with coroutines for Ko…
41ba453 
…tlin/Core
@ice-phoenix
Add syncGrammarWithKotlinGrammarApache2Repo pseudo task
3cee246
belyaev-mikhail
belyaev-mikhail commented May 17, 2021
View reviewed changes
docs/src/md/kotlin.core/coroutines.md

> Important: an exception to this rule are non-suspending inlined lambda parameters: if the higher-order function invoking such a lambda is called from a suspending function, this lambda is allowed to also have suspension points and call other suspending functions.

TODO(Cover other possible exceptions w.r.t. `inline`/`noinline`/`crossinline` combinations)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um, there aren't any afaik?

ice-phoenix
ice-phoenix approved these changes May 18, 2021
View reviewed changes
@ice-phoenix ice-phoenix marked this pull request as ready for review May 18, 2021 14:26
@ice-phoenix ice-phoenix merged commit 0daaf5d into release May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice-phoenix ice-phoenix ice-phoenix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.