Fixed support for Gradle < 8.2 #266
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshin
force-pushed
the
fix-support-old-gardle
branch
from
7d0caff to
7d9038b
Compare
JakeWharton
reviewed
Jul 31, 2024
Comment on lines
+650
to
+658
| private fun Project.isGradle8Dot2OrHigher(): Boolean { | ||
| val parts = gradle.gradleVersion.split('.') | ||
| if (parts.size < 2) return false | ||
| val major = parts[0].toIntOrNull() ?: return false | ||
| val minor = parts[1].toIntOrNull() ?: return false | ||
| if (major < 8) return false | ||
| if (major == 8 && minor < 2) return false | ||
| return true | ||
| } |
There was a problem hiding this comment.
See #265 which uses Gradle's GradleVersion API that obviates the need to do any manual version parsing like this.
There was a problem hiding this comment.
Indeed, thanks, missed that PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263