Align klib validation behavior for empty projects with other targets #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshin
reviewed
Jul 5, 2024
src/main/kotlin/-Utils.kt
Outdated
| @@ -56,7 +56,6 @@ public class KlibDumpMetadata( | |||
| * Instead, a dependent task will be skipped. | |||
shanshin
approved these changes
Jul 5, 2024
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
…th other targets Closes Kotlin/binary-compatibility-validator#246 Pull request Kotlin/binary-compatibility-validator#247
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
…th other targets Closes Kotlin/binary-compatibility-validator#246 Pull request Kotlin/binary-compatibility-validator#247
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
…th other targets Closes Kotlin/binary-compatibility-validator#246 Pull request Kotlin/binary-compatibility-validator#247
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
…th other targets Closes Kotlin/binary-compatibility-validator#246 Pull request Kotlin/binary-compatibility-validator#247 Moved from Kotlin/binary-compatibility-validator@e2c1ae3
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
…th other targets Closes Kotlin/binary-compatibility-validator#246 Pull request Kotlin/binary-compatibility-validator#247 Moved from Kotlin/binary-compatibility-validator@e2c1ae3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #243 resolution, JVM/JVM on KMP/KMP projects validation behavior remained different for projects without non-test sources or without published API:
apiCheckexecution;This PR addresses #246 and aligns KMP validation behavior for empty projects with how JVM ABI validation works for them.