Initial Gradle convention plugins #123
Conversation
|
I think it would be best to wait for #122 before reviewing this one, but it is convenient to point it at a specific branch! |
|
@qwwdfsad I think this PR was closed automatically by GitHub because the branch pr/122 was deleted. Could it be re-opened please? |
|
Sorry for the inconvenience, I took a shortcut and removed the pr/122 to re-instantiate it 😅 |
|
Hi, could you please elaborate on whether you have any plans to push this change forward? |
|
@qwwdfsad Ready for review! But could you update https://github.com/Kotlin/binary-compatibility-validator/tree/pr/122 to include the latest changes from master? |
aSemy
force-pushed
the
feat/initial_convention_plugins
branch
from
7496f3f to
e26b0ae
Compare
|
I've abandoned Not a blocker anyway, will start reviewing, but could you please change the base branch and rebase on it? |
| * Copyright 2016-2023 JetBrains s.r.o. | ||
| * Use of this source code is governed by the Apache 2.0 License that can be found in the LICENSE.txt file. | ||
| */ | ||
| package kotlinx.validation.build.conventions |
There was a problem hiding this comment.
Is it correct that these conventions will be published along with BCV and will be applicable to target's projects manually?
Could you please add an integration test for that?
There was a problem hiding this comment.
These convention plugins are only available in BCV's own build scripts for building BCV, and they are not published anywhere. They won't be visible for users at all.
These are pre-compiled script plugins which Gradle will auto-magically compile into a plugin with a plugin ID (based on the file path). The plugins are compiled into a JAR, buildSrc/build/libs/buildSrc.jar, which (because they're in buildSrc) is automatically added to the buildscript classpath.
Oops, I got the branches confused. |
- bump Gradle Plugin Publish Plugin version - build script updates & improvements - use Java Toolchains to set Java version - use jvm-test-fixtures plugin for functionalTest sources
- create convention plugins for common and java-specific config - add Gradle version catalog - simplify some build config
aSemy
force-pushed
the
feat/initial_convention_plugins
branch
from
e26b0ae to
84857fb
Compare
- create convention plugins for common and java-specific config - add Gradle version catalog - simplify some build config
* Annotate file paths with `@Language("file-reference")` (#126)
* Update to Gradle 8 (#122)
* bump Gradle Plugin Publish Plugin version
* build script updates & improvements
* use Java Toolchains to set the Java version
* use jvm-test-fixtures plugin for functionalTest sources
* update build config, remove redundant Maven publication
* Initial Gradle convention plugins (#123)
* Apply BCV, commit API dump (#131)
* The ABI shape will be reduced in the future, this is a technical change
* java-diff-utils
* Update Gradle to 8.5
---------
Co-authored-by: aSemy <[email protected]>
Depends on #122 - and again, this PR should contain no functional changes to the BCV plugin or library.